[webkit-reviews] review granted: [Bug 132024] [iOS] WebKit2 File Upload Support : [Attachment 230403] [PATCH] Addressed Comments

[bugzilla-daemon at webkit.org]

Enrica Casucci <enrica at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 132024: [iOS] WebKit2 File Upload Support
https://bugs.webkit.org/show_bug.cgi?id=132024

Attachment 230403: [PATCH] Addressed Comments
https://bugs.webkit.org/attachment.cgi?id=230403&action=review

------- Additional Comments from Enrica Casucci <enrica at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230403&action=review


The patch looks good. One remaining question: don't you need to handle
rotation? I know we do it for select elements and for the airplay picker.

>>> Source/WebKit2/ChangeLog:9
>>> +	     Include MobileCoreServices on iOS for kUTTypeImage/kUTTypeMovie.
>> 
>> Couldn't you soft link MobileCoreServices? We already do that in WebCore and
I think it would be more performant.
> 
> I figure there is no advantage to soft linking it if UIKit is hard linking it
and this hard links UIKit, but maybe my understanding of this is flawed.

You are right, I forgot we link UIKit.

> Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:653
> +    NSString *imageCountString, *videoCountString;

Split over two lines.

> Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:654
> +    NSString *imageString, *videoString;

Ditto