[webkit-reviews] review requested: [Bug 123828] AX: .js dialogs shown in unload while AX is running crash WebKit. : [Attachment 230435] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 29 16:12:29 PDT 2014


chris fleizach <cfleizach at apple.com> has asked	for review:
Bug 123828: AX: .js dialogs shown in unload while AX is running crash WebKit.
https://bugs.webkit.org/show_bug.cgi?id=123828

Attachment 230435: patch
https://bugs.webkit.org/attachment.cgi?id=230435&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
Using the run loop spinning is now guarded by this method

bool WebPage::synchronousMessagesShouldSpinRunLoop()
{
#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101000
    return WebCore::AXObjectCache::accessibilityEnabled();
#endif
    return false;
}


More information about the webkit-reviews mailing list