[webkit-reviews] review granted: [Bug 132320] [Mac, iOS] Support caption activation via JS webkitHasClosedCaptions method : [Attachment 230413] Revised to only call JS methods, not reprocess script each time.

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 132320: [Mac, iOS] Support caption activation via JS
webkitHasClosedCaptions method
https://bugs.webkit.org/show_bug.cgi?id=132320

Attachment 230413: Revised to only call JS methods, not reprocess script each
time.
https://bugs.webkit.org/attachment.cgi?id=230413&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230413&action=review


> Source/WebCore/ChangeLog:3
> +	   [Mac, iOS] Support caption activation via JS webkitHasClosedCaptions
methoNeed a short description (OOPS!).

Oops - "... methoNeed a short description (OOPS!)."

> Source/WebCore/html/HTMLMediaElement.cpp:3719
> +    if (!m_mediaControlsHost)
> +	   m_mediaControlsHost = MediaControlsHost::create(this);

It is created in didAddUserAgentShadowRoot, so I think we are in deep trouble
if we get here and m_mediaControlsHost is NULL, so an ASSERT might be more
appropriate.