[webkit-reviews] review granted: [Bug 132298] [New Multicolumn] Implement support for compositing : [Attachment 230410] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 132298: [New Multicolumn] Implement support for compositing
https://bugs.webkit.org/show_bug.cgi?id=132298

Attachment 230410: Patch
https://bugs.webkit.org/attachment.cgi?id=230410&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230410&action=review


> Source/WebCore/rendering/RenderLayer.cpp:2065
> +		       location.moveBy(region->topLeftLocation() +
-parentLayer->renderBox()->topLeftLocation());

+ - -> -?

> Source/WebCore/rendering/RenderMultiColumnSet.cpp:826
> +    LayoutUnit blockOffset = initialBlockOffset + (isHorizontalWritingMode()
? -flowThreadPortion.y() : -flowThreadPortion.x());

Change the plus with two minuses into a minus?

> LayoutTests/ChangeLog:10
> +	   * compositing/columns/composited-columns-vertical-rl.html:

I don't think you meant to change this.