[webkit-reviews] review granted: [Bug 132350] AX: [PATCH] procedures for automated atk text and caret tests : [Attachment 230405] auto tests for testatk.c

[bugzilla-daemon at webkit.org]

Jarek Czekalski <jarekczek at poczta.onet.pl> has granted	review:
Bug 132350: AX: [PATCH] procedures for automated atk text and caret tests
https://bugs.webkit.org/show_bug.cgi?id=132350

Attachment 230405: auto tests for testatk.c
https://bugs.webkit.org/attachment.cgi?id=230405&action=review

------- Additional Comments from Jarek Czekalski <jarekczek at poczta.onet.pl>
testatk.c lacks a convenient machinery to quickly add more test. I have an idea
how to improve it. I think of a test that would get 2 things on input:

1. html source
2. corresponding text

The test procedure would verify 3 things:

A. Whether all text atk components summed up give the expected text.
B. Whether caret may be inserted into all text components at all offsets.
C. Whether caret movements cause text-caret-moved events.

What a conincidence, recently I reported 3 bugs, each of them fails at another
testing part. They are bug #130941, bug #131933, bug #132349.

I attach the testatk.c patch that prepares testing procedures and 3 test cases.
If this could be committed, let's comment out the code adding these test cases,
so that tests not fail until they are fixed.