[webkit-reviews] review requested: [Bug 132222] Don't snapshot plugins that are overlaid with images. : [Attachment 230351] patch

[bugzilla-daemon at webkit.org]

Jon Lee <jonlee at apple.com> has asked  for review:
Bug 132222: Don't snapshot plugins that are overlaid with images.
https://bugs.webkit.org/show_bug.cgi?id=132222

Attachment 230351: patch
https://bugs.webkit.org/attachment.cgi?id=230351&action=review

------- Additional Comments from Jon Lee <jonlee at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230351&action=review


It would be nice to include some logging so that it is easy to see what’s
happening if we turn the channel on.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4388
> +	       

Please remove the extraneous whitespace sprinkled throughout this patch.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4401
> +	       inflatedPluginRect.setY(inflatedPluginRect.y() - yOffset);

Isn’t this what inflate() is for?