[webkit-reviews] review denied: [Bug 132320] [Mac, iOS] Support caption activation via JS webkitHasClosedCaptions method : [Attachment 230355] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has denied Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 132320: [Mac, iOS] Support caption activation via JS
webkitHasClosedCaptions method
https://bugs.webkit.org/show_bug.cgi?id=132320

Attachment 230355: Patch
https://bugs.webkit.org/attachment.cgi?id=230355&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230355&action=review


> Source/WebCore/html/HTMLMediaElement.cpp:3724
> +bool HTMLMediaElement::callMediaControlsJSFunction(const String&
functionName)
> +{
> +    LOG(Media, "HTMLMediaElement::callMediaControlsJSFunction");
> +    Page* page = document().page();
> +    if (!page)
> +	   return false;
> +    
> +    String mediaControlsScript =
RenderTheme::themeForPage(page)->mediaControlsScript();
> +    if (!mediaControlsScript.length())
> +	   return false;
> +    
> +    DOMWrapperWorld& world = ensureIsolatedWorld();

Won't this recreates the script each time it is called? Instead, I think you
want to do this the same way we update the script every time the page scale
changes. See the static function setPageScaleFactorProperty in
HTMLMediaElement.