[webkit-reviews] review granted: [Bug 132321] AX: SpeechSynthesisUtterance cannot addEventListener : [Attachment 230358] patch

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 132321: AX: SpeechSynthesisUtterance cannot addEventListener
https://bugs.webkit.org/show_bug.cgi?id=132321

Attachment 230358: patch
https://bugs.webkit.org/attachment.cgi?id=230358&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=230358&action=review


It looks good to me, but please take into consideration my comments below
(should they make sense to you too). Thanks!

> Source/WebCore/Modules/speech/SpeechSynthesisUtterance.idl:40
> +    void addEventListener(DOMString type, EventListener listener, optional
boolean useCapture);
> +    void removeEventListener(DOMString type, EventListener listener,
optional boolean useCapture);

I know you probably don't need it for this specific case, but wouldn't it be a
good idea to add EventTarget's dispatchEvent() here too, so the implementation
of that interface is complete insite SpeechSynthesisUtterance?

Also, for consistency with other IDLs (e.g. html/MediaController.idl,
html/track/TextTrack.idl...), I guess I would add these methods to the end with
a comment "// EventTarget interface" on top for clarity.