[webkit-reviews] review granted: [Bug 132309] Scrollbars do not update properly when topContentInset changes dynamically : [Attachment 230331] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 132309: Scrollbars do not update properly when topContentInset changes
dynamically
https://bugs.webkit.org/show_bug.cgi?id=132309

Attachment 230331: Patch
https://bugs.webkit.org/attachment.cgi?id=230331&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230331&action=review


> Source/WebCore/page/FrameView.cpp:962
> +    // To fully update scrollbars, we need to call both updateScrolbars()
and frameViewDidChangeSize() which will
> +    // will update all of the scrolling-related layers.

I don't think the comment is necessary.

> Source/WebCore/page/FrameView.cpp:964
> +    if (RenderView* renderView = this->renderView()) {

We already have a local and already early returned for RenderView.