[webkit-reviews] review granted: [Bug 132115] WebKit2 View Gestures (Swipe): Discard snapshots made with a different view size/pixel density : [Attachment 230251] pulled crash fix into another bug

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 132115: WebKit2 View Gestures (Swipe): Discard snapshots made with a
different view size/pixel density
https://bugs.webkit.org/show_bug.cgi?id=132115

Attachment 230251: pulled crash fix into another bug
https://bugs.webkit.org/attachment.cgi?id=230251&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230251&action=review


> Source/WebKit2/ChangeLog:9
> +	   To do this, we need an accurate picture of the topContentInset, both
for the Web view,

"picture" in the context of snapshotting is ... confusing.

> Source/WebKit2/UIProcess/mac/ViewGestureController.h:137
> +    CALayer *determineSnapshotLayerParent();
> +    CALayer *determineLayerAdjacentToSnapshotForParent(SwipeDirection,
CALayer *snapshotLayerParent);

Not sure why these aren't const.