[webkit-reviews] review canceled: [Bug 131941] [CMake] Add support for building with Clang's AddressSanitizer : [Attachment 230291] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 28 09:48:38 PDT 2014


Zan Dobersek <zandobersek at gmail.com> has canceled Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 131941: [CMake] Add support for building with Clang's AddressSanitizer
https://bugs.webkit.org/show_bug.cgi?id=131941

Attachment 230291: Patch
https://bugs.webkit.org/attachment.cgi?id=230291&action=review

------- Additional Comments from Zan Dobersek <zandobersek at gmail.com>
This is just over-engineered.

I'll re-check if it's possible to build simply by listing the -fsanitize option
in CFLAGS, CXXFLAGS and LDFLAGS. If not, a much simpler approach would be to
have a single option, named ENABLE_COMPILER_SANITIZERS or similar. It would be
set with a comma-separated list of values and would work with both GCC and
Clang.


More information about the webkit-reviews mailing list