[webkit-reviews] review granted: [Bug 132176] [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB : [Attachment 230278] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 27 21:36:33 PDT 2014


Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Joonghun Park
<jh718.park at samsung.com>'s request for review:
Bug 132176: [EFL] Remove indexedDB's dependency on leveldb and disable
indexedDB
https://bugs.webkit.org/show_bug.cgi?id=132176

Attachment 230278: Patch
https://bugs.webkit.org/attachment.cgi?id=230278&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230278&action=review


LGTM. Please land this patch after adding my suggestion.

> Tools/ChangeLog:7
> +

It would be good if you mention why EFL port remove indexedDB dependency in
ChangeLog. For example,

"EFL port will use sqlite to support indexedDB. So, this patch removes levelDB
dependency for now."


More information about the webkit-reviews mailing list