[webkit-reviews] review granted: [Bug 132223] [Cocoa] -[WKWebProcessPlugInController parameters] returns nil if no parameters have been set yet : [Attachment 230249] Create m_bundleParameters if needed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 27 15:45:26 PDT 2014


Sam Weinig <sam at webkit.org> has granted mitz at webkit.org <mitz at webkit.org>'s
request for review:
Bug 132223: [Cocoa] -[WKWebProcessPlugInController parameters] returns nil if
no parameters have been set yet
https://bugs.webkit.org/show_bug.cgi?id=132223

Attachment 230249: Create m_bundleParameters if needed
https://bugs.webkit.org/attachment.cgi?id=230249&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=230249&action=review


> Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:137
> +	   m_bundleParameters = adoptNS([[WKWebProcessBundleParameters alloc]
initWithDictionary:[NSDictionary dictionary]]);

Maybe @{ } instead of [NSDictionary dictionary]?


More information about the webkit-reviews mailing list