[webkit-reviews] review granted: [Bug 132228] [GTK] TextTrack kind and mode attributes are enums since r166180 : [Attachment 230257] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 132228: [GTK] TextTrack kind and mode attributes are enums since r166180
https://bugs.webkit.org/show_bug.cgi?id=132228

Attachment 230257: Patch
https://bugs.webkit.org/attachment.cgi?id=230257&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=230257&action=review


Looks good with a few minor suggestions.

> Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp:74
> +    gchar* result = convertToUTF8String(item->kind());
> +    return result;

Can you just return convertToUTF8String(item->kind()); ?

> Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp:103
> +    WebCore::TextTrack* item = WebKit::core(self);
> +    WTF::String convertedValue = WTF::String::fromUTF8(value);
> +    item->setMode(convertedValue);

Can't this just be WebKit::core(self)->setMode(WTF::String::fromUTF8(value)); ?