[webkit-reviews] review granted: [Bug 132204] REGRESSION (r167775): Safari crashes in ViewSnapshotStore::pruneSnapshots after loading 20 pages : [Attachment 230245] followup
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Apr 26 19:36:59 PDT 2014
mitz at webkit.org <mitz at webkit.org> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 132204: REGRESSION (r167775): Safari crashes in
ViewSnapshotStore::pruneSnapshots after loading 20 pages
https://bugs.webkit.org/show_bug.cgi?id=132204
Attachment 230245: followup
https://bugs.webkit.org/attachment.cgi?id=230245&action=review
------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=230245&action=review
> Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:113
> + if (snapshotIter == m_snapshotMap.end()) {
> + ASSERT_NOT_REACHED();
> + return;
> + }
This is better written as
ASSERT(snapshotIter != m_snapshotMap.end());
if (snapshowIter == m_snapshotMap.end())
return;
Since the assertion failure message will say what is the condition that was
false.
More information about the webkit-reviews
mailing list