[webkit-reviews] review granted: [Bug 132043] TouchEvent is not handled after releasing any point among touched points. : [Attachment 230055] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 25 14:42:53 PDT 2014


Benjamin Poulain <benjamin at webkit.org> has granted EunMi Lee
<eunmi15.lee at samsung.com>'s request for review:
Bug 132043: TouchEvent is not handled after releasing any point among touched
points.
https://bugs.webkit.org/show_bug.cgi?id=132043

Attachment 230055: Patch
https://bugs.webkit.org/attachment.cgi?id=230055&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=230055&action=review


Thanks for fixing this!

> Source/WebKit2/UIProcess/WebPageProxy.cpp:1496
> +bool WebPageProxy::areAllTouchPointsReleased(const WebTouchEvent& event)
const

This should not be a member of WebPageProxy, the function does not need to
access any of the states of WebPageProxy, it should be an utility static
function in the implementation file.


More information about the webkit-reviews mailing list