[webkit-reviews] review granted: [Bug 132204] REGRESSION (r167775): Safari crashes in ViewSnapshotStore::pruneSnapshots after loading 20 pages : [Attachment 230199] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 25 14:23:46 PDT 2014


Anders Carlsson <andersca at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 132204: REGRESSION (r167775): Safari crashes in
ViewSnapshotStore::pruneSnapshots after loading 20 pages
https://bugs.webkit.org/show_bug.cgi?id=132204

Attachment 230199: patch
https://bugs.webkit.org/attachment.cgi?id=230199&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230199&action=review


> Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:79
> +	   const auto& snapshot = m_snapshotMap.find(snapshotUUID);

I don't think you should call this snapshot since it's an iterator. How about 

auto snapshotIt = m_snapshotMap.find(snapshotUUID)


More information about the webkit-reviews mailing list