[webkit-reviews] review granted: [Bug 131023] [CSS Grid Layout] Clamping the number of repetitions in repeat() : [Attachment 230164] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Javier Fernandez
<jfernandez at igalia.com>'s request for review:
Bug 131023: [CSS Grid Layout] Clamping the number of repetitions in repeat()
https://bugs.webkit.org/show_bug.cgi?id=131023

Attachment 230164: Patch
https://bugs.webkit.org/attachment.cgi?id=230164&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=230164&action=review


This patch seems fine overall. Please make make the MAX_REPETITIONS name more
descriptive when you land.

>> Source/WebCore/css/CSSParser.cpp:4930
>> +	    repetitions = MAX_REPETITIONS;
> 
> Should there be any kind of feedback to the inspector when this happens?

Also: I think you should reference the specification or draft that specifies
this limit, and call the variable "MAX_GRID_TRACK_REPETITIONS".