[webkit-reviews] review granted: [Bug 132195] Allow a platform-specific size enumeration to be passed into popup-menu display : [Attachment 230181] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 132195: Allow a platform-specific size enumeration to be passed into
popup-menu display
https://bugs.webkit.org/show_bug.cgi?id=132195

Attachment 230181: Patch
https://bugs.webkit.org/attachment.cgi?id=230181&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=230181&action=review


r=me. It looks like no similar changes are needed for iOS, right?

> Source/WebKit2/WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm:38
> +void WebPopupMenu::setUpPlatformData(const IntRect& pageRect,
PlatformPopupMenuData& data)

It doesn't seem like you use pageRect anywhere.