[webkit-reviews] review granted: [Bug 132050] [CSS Regions] Rename objectShouldPaintInFlowRegion to something more clear : [Attachment 230180] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 25 09:04:09 PDT 2014
Andreas Kling <akling at apple.com> has granted Radu Stavila <stavila at adobe.com>'s
request for review:
Bug 132050: [CSS Regions] Rename objectShouldPaintInFlowRegion to something
more clear
https://bugs.webkit.org/show_bug.cgi?id=132050
Attachment 230180: Patch
https://bugs.webkit.org/attachment.cgi?id=230180&action=review
------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230180&action=review
r=me
> Source/WebCore/rendering/RenderFlowThread.cpp:810
> +bool RenderFlowThread::objectShouldFragmentInFlowRegion(const RenderObject*
object, const RenderRegion* region) const
> {
> ASSERT(object);
> ASSERT(region);
The two ASSERTs here indicate that the arguments should really be references
instead of pointers.
That kind of change does not belong in this patch though.
More information about the webkit-reviews
mailing list