[webkit-reviews] review denied: [Bug 132180] [GTK] Implement iframe shim technique for windowed plugins in WebKit2 : [Attachment 230170] Try to fix mac and EFL builds

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 132180: [GTK] Implement iframe shim technique for windowed plugins in
WebKit2
https://bugs.webkit.org/show_bug.cgi?id=132180

Attachment 230170: Try to fix mac and EFL builds
https://bugs.webkit.org/attachment.cgi?id=230170&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=230170&action=review


GTK+ bits look good to me.

> Source/WebKit2/WebProcess/Plugins/PluginView.cpp:1027
> +static bool iframeIsAbovePlugin(const Vector<const RenderObject*>&
iframeZIndexStack, const Vector<const RenderObject*>& pluginZIndexStack)
> +{
> +    for (size_t i = 0; i < iframeZIndexStack.size() && i <
pluginZIndexStack.size(); ++i) {
> +	   // The root is at the end of these stacks. We want to iterate
root-downwards so we index backwards from the end.
> +	   const RenderObject* iframeStackRootObject =
iframeZIndexStack[iframeZIndexStack.size() - 1 - i];
> +	   const RenderObject* pluginStackRootObject =
pluginZIndexStack[pluginZIndexStack.size() - 1 - i];

This requires preserving the original copyright, I think.