[webkit-reviews] review granted: [Bug 132160] [iOS WebKit2] RemoteLayerTreeDrawingArea::flushLayers() should force CA to garbage collect surfaces. : [Attachment 230125] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 132160: [iOS WebKit2] RemoteLayerTreeDrawingArea::flushLayers() should
force CA to garbage collect surfaces.
https://bugs.webkit.org/show_bug.cgi?id=132160

Attachment 230125: Patch
https://bugs.webkit.org/attachment.cgi?id=230125&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230125&action=review


> Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:288
> +    [CATransaction begin];

I wonder if it's better to do this in didUpdate() instead; we're more likely to
actually do something more immediately useful then, because by that point we
would (ideally but not always) have pushed the new front surfaces to CA.