[webkit-reviews] review granted: [Bug 132151] Mark Supplement instead of RefCountedSupplement in NavigatorContentUtils : [Attachment 230114] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 24 17:13:59 PDT 2014
Darin Adler <darin at apple.com> has granted Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 132151: Mark Supplement instead of RefCountedSupplement in
NavigatorContentUtils
https://bugs.webkit.org/show_bug.cgi?id=132151
Attachment 230114: Patch
https://bugs.webkit.org/attachment.cgi?id=230114&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230114&action=review
> Source/WebCore/Modules/navigatorcontentutils/NavigatorContentUtils.h:58
> + static PassOwnPtr<NavigatorContentUtils>
create(std::unique_ptr<NavigatorContentUtilsClient>);
Should use std::unique_ptr, not PassOwnPtr, in new code. But I guess we need to
fix all Supplement implementers at once.
More information about the webkit-reviews
mailing list