[webkit-reviews] review granted: [Bug 132090] Web Inspector: CSS autofill suggests properties instead of values when values are needed : [Attachment 230108] [PATCH] Proposed Fix: Updated to CSS mode handling to fix autocomplete, other issues

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Jono Wells
<jonowells at apple.com>'s request for review:
Bug 132090: Web Inspector: CSS autofill suggests properties instead of values
when values are needed
https://bugs.webkit.org/show_bug.cgi?id=132090

Attachment 230108: [PATCH] Proposed Fix: Updated to CSS mode handling to fix
autocomplete, other issues
https://bugs.webkit.org/attachment.cgi?id=230108&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=230108&action=review


r=me

> Source/WebInspectorUI/ChangeLog:13
> +	   data structure. All references to state.stack are obscelete. Many

Typo: obscelete

> Source/WebInspectorUI/ChangeLog:884
> -	   Add missing semicolon.	 
> +	   Add missing semicolon.

I wonder if commit queue will allow a patch that fixes this trailing
whitespace. Maybe it will, maybe it won't.

> Source/WebInspectorUI/Tools/PrettyPrinting/CodeMirrorFormatters.js:398
> +	   if (!state.stack || !state.stack.length || state.stack.lastValue ===
"@media{")

These only fix the exception, but I assume they don't make CSS pretty printing
work?