[webkit-reviews] review granted: [Bug 132136] [iOS WebKit2] Should properly handle focus redirect (keyboard state changes when focus changes) : [Attachment 230106] Patch2

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Enrica Casucci
<enrica at apple.com>'s request for review:
Bug 132136: [iOS WebKit2] Should properly handle focus redirect (keyboard state
changes when focus changes)
https://bugs.webkit.org/show_bug.cgi?id=132136

Attachment 230106: Patch2
https://bugs.webkit.org/attachment.cgi?id=230106&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=230106&action=review


> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:317
> +    RefPtr<Frame> oldFocusedFrame =
m_page->focusController().focusedFrame();
> +    RefPtr<Element> oldFocusedElement = oldFocusedFrame ?
oldFocusedFrame->document()->focusedElement() : nullptr;
> +    m_userIsInteracting = true;

I believe you will need the same logic in WebPage::dispatchTouchEvent().