[webkit-reviews] review granted: [Bug 132114] WebKit2 View Gestures: Use a single struct for the snapshot, and pass it around : [Attachment 230100] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 132114: WebKit2 View Gestures: Use a single struct for the snapshot, and
pass it around
https://bugs.webkit.org/show_bug.cgi?id=132114

Attachment 230100: patch
https://bugs.webkit.org/attachment.cgi?id=230100&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230100&action=review


> Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:89
> +#if USE(IOSURFACE)
> +	   if (!snapshot->value.surface)
> +	       continue;
> +#else
> +	   if (!snapshot->value.image)
> +	       continue;
> +#endif

Put in a member function on Snapshot?

> Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:101
> +#if USE(IOSURFACE)
> +	   snapshot->value.surface = nullptr;
> +#else
> +	   snapshot->value.image = nullptr;
> +#endif

Put in a member function on Snapshot?

> Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:122
> +#if USE(IOSURFACE)
> +    snapshot->value.surface = nullptr;
> +#else
> +    snapshot->value.image = nullptr;
> +#endif

Call said member function?