[webkit-reviews] review granted: [Bug 130966] Implement Array.prototype.find() : [Attachment 230068] Patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Antoine Quint <graouts at webkit.org>'s
request for review:
Bug 130966: Implement Array.prototype.find()
https://bugs.webkit.org/show_bug.cgi?id=130966

Attachment 230068: Patch
https://bugs.webkit.org/attachment.cgi?id=230068&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230068&action=review


r=me, but add edge case tests before landing

>> Source/JavaScriptCore/builtins/Array.prototype.js:198
>> +	    throw new @TypeError("Array.prototype.find requires that |this| not
be undefined");
> 
> I don’t see any test coverage of this.

Add .find.call(...) tests

>> Source/JavaScriptCore/builtins/Array.prototype.js:204
>> +	    throw new @TypeError("Array.prototype.find callback must be a
function");
> 
> I don’t see any test coverage of this.

coverage test

>> Source/JavaScriptCore/builtins/Array.prototype.js:226
>> +	    throw new @TypeError("Array.prototype.findIndex callback must be a
function");
> 
> I don’t see any test coverage of this.

ditto