[webkit-reviews] review granted: [Bug 132096] [iOS] Manage AudioSession category according to media type : [Attachment 230077] Updated patch - now with fewer bogus style errors!

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 132096: [iOS] Manage AudioSession category according to media type
https://bugs.webkit.org/show_bug.cgi?id=132096

Attachment 230077: Updated patch - now with fewer bogus style errors!
https://bugs.webkit.org/attachment.cgi?id=230077&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230077&action=review


r=me, with nits.

> Source/WebCore/platform/audio/mac/MediaSessionManagerMac.cpp:62
> +    if (has(MediaSession::WebAudio)) {
> +	   if (count(MediaSession::WebAudio) == 1)
> +	       AudioSession::sharedSession().setActive(1);
> +    } else
> +	   AudioSession::sharedSession().setActive(0);

the `0` and `1` should be `true` and `false`.  

setActive() should be safe to call multiple times with the same argument, which
would greatly simplify this area of code.