[webkit-reviews] review granted: [Bug 132092] [wk2] Provide SPI allowing clients to hand events directly to swipe code, bypassing scrolling : [Attachment 230026] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 132092: [wk2] Provide SPI allowing clients to hand events directly to swipe
code, bypassing scrolling
https://bugs.webkit.org/show_bug.cgi?id=132092

Attachment 230026: patch
https://bugs.webkit.org/attachment.cgi?id=230026&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230026&action=review


> Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm:106
> +    , m_ignorePinnedState(false)

We try to have these be adjective phrases instead of verb phrases. That’s why
the name will often be something like m_shouldIgnorePinnedState.