[webkit-reviews] review denied: [Bug 130715] [CSS Regions] Overflow selection doesn't work properly : [Attachment 229964] Patch implementing reviewer feedback

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Radu Stavila <stavila at adobe.com>'s
request for review:
Bug 130715: [CSS Regions] Overflow selection doesn't work properly
https://bugs.webkit.org/show_bug.cgi?id=130715

Attachment 229964: Patch implementing reviewer feedback
https://bugs.webkit.org/attachment.cgi?id=229964&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229964&action=review


Close! One issue.

> Source/WebCore/rendering/RenderMultiColumnSet.cpp:921
> +		   return multiColumnFlowThread()->positionForPoint(point,
region);

This is wrong. You should be passing "this" in here... it's similar to what you
did for RenderRegion.cpp.

> Source/WebCore/rendering/RenderMultiColumnSet.cpp:958
> +		   return multiColumnFlowThread()->positionForPoint(point,
region);

Same here.