[webkit-reviews] review granted: [Bug 132106] [Cocoa] fix CF leaks found by code inspection : [Attachment 230044] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 132106: [Cocoa] fix CF leaks found by code inspection
https://bugs.webkit.org/show_bug.cgi?id=132106

Attachment 230044: Patch
https://bugs.webkit.org/attachment.cgi?id=230044&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230044&action=review


r=me. Nice finds!

> Source/WebCore/plugins/mac/PluginPackageMac.cpp:138
> +	   RetainPtr<CFStringRef> homeDir =
adoptCF(homeDirectoryPath().createCFString());

We don't need adoptCF() here; createCFString() returns a
RetainPtr<CFStringRef>.

> Source/WebCore/plugins/mac/PluginPackageMac.cpp:255
> +    RetainPtr<CFStringRef> path = adoptCF(m_path.createCFString());

Ditto.