[webkit-reviews] review denied: [Bug 132043] TouchEvent is not handled after releasing any point among touched points. : [Attachment 229963] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied EunMi Lee
<eunmi15.lee at samsung.com>'s request for review:
Bug 132043: TouchEvent is not handled after releasing any point among touched
points.
https://bugs.webkit.org/show_bug.cgi?id=132043

Attachment 229963: Patch
https://bugs.webkit.org/attachment.cgi?id=229963&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=229963&action=review


> Source/WebKit2/UIProcess/WebPageProxy.cpp:1532
> -    if (event.type() == WebEvent::TouchEnd || event.type() ==
WebEvent::TouchCancel)
> +    if ((event.touchPoints().size() <= 1 && event.type() ==
WebEvent::TouchEnd) || event.type() == WebEvent::TouchCancel)

You are right, I completely mishandled multitouch here. :(

Unfortunately checking for the size of touchPoints() is not enough. You could
have two touch points simultaneously in touchEnd or touchCancel. You will need
to loop over the touch points and find if they are all released or canceled.

Can you please do that in a little utility function? I separated the iOS touch
event dispatch recently and the same bug exist in there.