[webkit-reviews] review denied: [Bug 132030] [OS X] Make checking if a font is the system font more robust : [Attachment 230010] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 132030: [OS X] Make checking if a font is the system font more robust
https://bugs.webkit.org/show_bug.cgi?id=132030

Attachment 230010: Patch
https://bugs.webkit.org/attachment.cgi?id=230010&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230010&action=review


I think you already landed this, but it was still marked review?

> Source/WebCore/platform/graphics/mac/FontMac.mm:546
> +    RetainPtr<CTFontDescriptorRef> descriptor =
CTFontCopyFontDescriptor(primaryFont()->platformData().ctFont());

This needs an adoptCF, otherwise it will be a storage leak.