[webkit-reviews] review granted: [Bug 132017] DocumentLoader::dataReceived assertion failed : [Attachment 230005] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted peavo at outlook.com's request for
review:
Bug 132017: DocumentLoader::dataReceived assertion failed
https://bugs.webkit.org/show_bug.cgi?id=132017

Attachment 230005: Patch
https://bugs.webkit.org/attachment.cgi?id=230005&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=230005&action=review


Wow -- uninitialized variables.

Double-check that network tests still pass with this change. That
'didReceiveResponse' might be needed to flush the client state in cases where
the response wasn't received earlier...

> Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:-687
> -		   d->client()->didReceiveResponse(job, d->m_response);

Its possible that this is needed in addition to the one you added above, to
handle cases where the client did not receive a valid/complete response, but
WebKit needs to be told to "move to the next state".

Maybe double-check that HTTP and network tests work properly after this change.