[webkit-reviews] review granted: [Bug 132077] [Mac, iOS] Stop buffering media when on an inactive tab : [Attachment 230011] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 23 15:03:29 PDT 2014


Eric Carlson <eric.carlson at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 132077: [Mac, iOS] Stop buffering media when on an inactive tab
https://bugs.webkit.org/show_bug.cgi?id=132077

Attachment 230011: Patch
https://bugs.webkit.org/attachment.cgi?id=230011&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=230011&action=review


> Source/WebCore/platform/audio/MediaSession.h:105
> +    bool m_elementIsHidden;

This is never initialized, but I don't know how it can be. Maybe it makes more
sense to not cache this state but to always ask the client?


More information about the webkit-reviews mailing list