[webkit-reviews] review granted: [Bug 120055] [GTK] wmode='transparent' for flash plugin doesn't work : [Attachment 229899] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 120055: [GTK] wmode='transparent' for flash plugin doesn't work
https://bugs.webkit.org/show_bug.cgi?id=120055

Attachment 229899: Patch
https://bugs.webkit.org/attachment.cgi?id=229899&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=229899&action=review


> Source/WebKit2/Shared/Plugins/PluginQuirks.h:94
> +	   // Some ports don't support windowed plugins.
> +	   ForceFlashWindowlessMode,
> +

Should this be under #if PLUGIN_ARCHITECTURE(X11)?

> Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:616
> +#endif

You're no longer injecting windowedPlugin=false for
application/x-webkit-test-netscape, I assume that's not required (anymore?).