[webkit-reviews] review granted: [Bug 132039] [EFL][WK1] There are many failures in fast/forms since r163033 : [Attachment 229954] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Ryuan Choi
<ryuan.choi at samsung.com>'s request for review:
Bug 132039: [EFL][WK1] There are many failures in fast/forms since r163033
https://bugs.webkit.org/show_bug.cgi?id=132039

Attachment 229954: Patch
https://bugs.webkit.org/attachment.cgi?id=229954&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229954&action=review


LGTM

> Source/WebKit/efl/ewk/ewk_view.cpp:3686
> +	   break;

Additionally, I think we need to add ASSERT_NOT_REACHED() when user passes
unsupported type.

    default:
	ASSERT_NOT_REACHED();
	break;