[webkit-reviews] review granted: [Bug 131115] prepare-Changelog and svn-create-patch should optionally run check-webkit-style. : [Attachment 228951] patch with review feedback

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted James Craig <jcraig at apple.com>'s
request for review:
Bug 131115: prepare-Changelog and svn-create-patch should optionally run
check-webkit-style.
https://bugs.webkit.org/show_bug.cgi?id=131115

Attachment 228951: patch with review feedback
https://bugs.webkit.org/attachment.cgi?id=228951&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=228951&action=review


> Tools/Scripts/svn-create-patch:112
> +    print STDERR "  Finished svn-create-patch. Running check-webkit-style.\n
 ";

How did you come to the decision to emit "Finished svn-create-patch"? I mean,
you didn't emit "Finished prepare-ChangeLog" in script
Tools/Scripts/prepare-ChangeLog. I don't see much value in emitting such a
message. Regardless, we should either omit such a message or emit a similar
message in prepare-ChangeLog for consistency.