[webkit-reviews] review granted: [Bug 132030] [OS X] Make checking if a font is the system font more robust : [Attachment 229925] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 132030: [OS X] Make checking if a font is the system font more robust
https://bugs.webkit.org/show_bug.cgi?id=132030

Attachment 229925: Patch
https://bugs.webkit.org/attachment.cgi?id=229925&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229925&action=review


> Source/WebCore/platform/graphics/mac/FontMac.mm:40
> +extern "C" bool CTFontDescriptorIsSystemUIFont(CTFontDescriptorRef);

Do we want to wrap this in a #if __MAC_MIN thing as well, to make it clear we
only use it on 1090+?

> Source/WebCore/platform/graphics/mac/FontMac.mm:545
> +#if __MAC_OS_X_VERSION_MIN_REQUIRED < 1090

So this existed on 10.9 as well?