[webkit-reviews] review denied: [Bug 132014] Add SPI to expose provisional and committed URL from Frame. : [Attachment 229896] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 22 14:12:50 PDT 2014


mitz at webkit.org <mitz at webkit.org> has denied Yongjun Zhang
<yongjun_zhang at apple.com>'s request for review:
Bug 132014: Add SPI to expose provisional and committed URL from Frame.
https://bugs.webkit.org/show_bug.cgi?id=132014

Attachment 229896: Patch.
https://bugs.webkit.org/attachment.cgi?id=229896&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=229896&action=review


>
Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePriva
te.h:41
> + at property (nonatomic, readonly) NSURL *_committedURL;

This is already exposed via the URL property. Other than that, looks good.


More information about the webkit-reviews mailing list