[webkit-reviews] review granted: [Bug 131967] [OS X] Glyph spacing for system fonts may be incorrect : [Attachment 229907] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 131967: [OS X] Glyph spacing for system fonts may be incorrect
https://bugs.webkit.org/show_bug.cgi?id=131967

Attachment 229907: Patch
https://bugs.webkit.org/attachment.cgi?id=229907&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229907&action=review


> Source/WebCore/ChangeLog:11
> +	   (WebCore::SimpleFontData::platformWidthForGlyph): Update to use
CTFontGetAdvancesForGlyphs() for system fonts

You don't explain the horizontal ? kCTFontHorizontalOrientation :
kCTFontVerticalOrientation change.

> Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm:384
> +    if ((horizontal || m_isBrokenIdeographFallback) &&
!hasCustomTracking(m_platformData.ctFont())) {

So much better!