[webkit-reviews] review granted: [Bug 131967] [OS X] Glyph spacing for system fonts may be incorrect : [Attachment 229852] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 131967: [OS X] Glyph spacing for system fonts may be incorrect
https://bugs.webkit.org/show_bug.cgi?id=131967

Attachment 229852: Patch
https://bugs.webkit.org/attachment.cgi?id=229852&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229852&action=review


> Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm:378
> +    if (
> +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
> +	       !CTFontDescriptorIsSystemUIFont(descriptor.get()) &&
> +#endif
> +	       (horizontal || m_isBrokenIdeographFallback)) {

I don't know the performance implications, but could you switch to have the
ALWAYS test first? That will make the style bot happy.