[webkit-reviews] review granted: [Bug 131911] [GTK] YCM choose a newer compile_commands.json in between Release or Debug : [Attachment 229801] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted ChangSeok Oh
<changseok.oh at collabora.com>'s request for review:
Bug 131911: [GTK] YCM choose a newer compile_commands.json in between Release
or Debug
https://bugs.webkit.org/show_bug.cgi?id=131911

Attachment 229801: Patch
https://bugs.webkit.org/attachment.cgi?id=229801&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=229801&action=review


> Tools/gtk/ycm_extra_conf.py:111
> +    webkitbuild_path = os.path.join(common.get_build_path(fatal=False),
'..')
> +    build_path = os.path.normpath(get_build_path(webkitbuild_path))

I don't think this needs to be an argument to get_build_path. Instead I think
that get_build_path can call common.get_build_path itself.