[webkit-reviews] review granted: [Bug 131939] Page::=?UTF-8?Q?setDefersLoading=20doesn=E2=80=99t=20do=20anything=20when=20using=20the=20Network=20process=20?=: [Attachment 229814] Add load deferring to NetworkResourceLoader

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted mitz at webkit.org
<mitz at webkit.org>'s request for review:
Bug 131939: Page::setDefersLoading doesn’t do anything when using the Network
process
https://bugs.webkit.org/show_bug.cgi?id=131939

Attachment 229814: Add load deferring to NetworkResourceLoader
https://bugs.webkit.org/attachment.cgi?id=229814&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=229814&action=review


Darin says:
'''
The patch looks exactly right to me.
'''

Maciej says:
'''
Taking Darin's comment as an r+ and moving to Prepare.
'''

> Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:151
> +	   m_request = m_deferredRequest;
> +	   m_deferredRequest = ResourceRequest();

Darin says:
'''
We’d get better efficiency if we added a move assignment operator to
ResourceRequest and used it there.
'''