[webkit-reviews] review granted: [Bug 131944] Need default WKNavigationDelegate behavior : [Attachment 229821] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 21 12:47:07 PDT 2014


mitz at webkit.org <mitz at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 131944: Need default WKNavigationDelegate behavior
https://bugs.webkit.org/show_bug.cgi?id=131944

Attachment 229821: Patch
https://bugs.webkit.org/attachment.cgi?id=229821&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=229821&action=review


> Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:229
> +#if !PLATFORM(IOS)
> +	   if (![nsURLRequest.URL isFileURL])
> +	       [[NSWorkspace sharedWorkspace] openURL:nsURLRequest.URL];
> +#endif

This should be #if USE(APPKIT).


More information about the webkit-reviews mailing list