[webkit-reviews] review granted: [Bug 131942] Check the com.apple.security.network.client entitlement for all processes : [Attachment 229817] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 21 12:08:28 PDT 2014


mitz at webkit.org <mitz at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 131942: Check the com.apple.security.network.client entitlement for all
processes
https://bugs.webkit.org/show_bug.cgi?id=131942

Attachment 229817: Patch
https://bugs.webkit.org/attachment.cgi?id=229817&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=229817&action=review


>
Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.m
m:59
> +    // FIXME: Once we're 100% sure that a process won't access the network
we can get rid of this requirement for all processes.

This should say “can’t” instead of “won’t”. We can be sure of this when the
sandbox of the process in question disallows network access.


More information about the webkit-reviews mailing list