[webkit-reviews] review granted: [Bug 131926] Compile the :root pseudo class and fix a related issue with :nth-child() : [Attachment 229789] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 131926: Compile the :root pseudo class and fix a related issue with
:nth-child()
https://bugs.webkit.org/show_bug.cgi?id=131926

Attachment 229789: Patch
https://bugs.webkit.org/attachment.cgi?id=229789&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229789&action=review


r=me

I was going to suggest that we add some DRT mechanism to explicitly disable the
selector JIT, but I suppose the fact that most ports are building without it
means that we are well covered on both code paths for the time being.

> Source/WebCore/cssjit/SelectorCompiler.cpp:1952
> +	   // Anything modulo 1 is zero. Unless b restrict the range, this does
not filter anything out.

restrict -> restricts

> Source/WebCore/cssjit/SelectorCompiler.cpp:1955
> +	   validSubsetFilters.append(slot);

You can use uncheckedAppend() here.