[webkit-reviews] review granted: [Bug 130534] Move cross-port Source/WebCore/page/ code to std::unique_ptr : [Attachment 229773] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 130534: Move cross-port Source/WebCore/page/ code to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=130534

Attachment 229773: Patch
https://bugs.webkit.org/attachment.cgi?id=229773&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229773&action=review


/Volumes/Data/EWS/WebKit/Source/WebKit/mac/WebView/WebHTMLRepresentation.mm:485
:60: error: reference to type 'const JSC::Yarr::RegularExpression' could not
bind to an lvalue of type 'JSC::Yarr::RegularExpression *'

r=me as long as you fix the Mac build

> Source/WebCore/page/DOMWindow.cpp:158
> +	   // This object gets deleted when std::unique_ptr falls out of
scope..
> +	   std::unique_ptr<PostMessageTimer> timer(this);
> +	   m_window->postMessageTimerFired(*timer);

Not sure this is better than just calling "delete this" at the end of the
function.

> Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1087
> +    CSSPropertyAnimationWrapperMap();

Why not leave this private?