[webkit-reviews] review granted: [Bug 131461] GenericHashTraits::peek() is producing copies of passed-in temporary values : [Attachment 229769] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 20 20:37:38 PDT 2014


Darin Adler <darin at apple.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 131461: GenericHashTraits::peek() is producing copies of passed-in
temporary values
https://bugs.webkit.org/show_bug.cgi?id=131461

Attachment 229769: Patch
https://bugs.webkit.org/attachment.cgi?id=229769&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229769&action=review


> Source/WTF/wtf/HashTraits.h:70
> +    template<typename U>
> +    static U&& peek(U&& value) { return std::forward<U>(value); }

I’d suggest doing this all on one line.


More information about the webkit-reviews mailing list