[webkit-reviews] review granted: [Bug 131468] Subpixel rendering: RenderLayer's size is set using enclosingRect() which can result in cruft. : [Attachment 229775] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Zalan Bujtas <zalan at apple.com>'s
request for review:
Bug 131468: Subpixel rendering: RenderLayer's size is set using enclosingRect()
which can result in cruft.
https://bugs.webkit.org/show_bug.cgi?id=131468

Attachment 229775: Patch
https://bugs.webkit.org/attachment.cgi?id=229775&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=229775&action=review


> Source/WebCore/rendering/RenderLayerBacking.cpp:715
> +    * GraphicsLayer: device pixel positioned. Positioned is floored, size is
ceiled.

I think this is a typo. “Position is floored”, is what you want. Also, it
should be either “ceil’d” or “ceilinged”.

It seems to me that combining “position is floored” with “size is ceilinged”
could result in incorrect behavior. If the position was 0.95 and the size was
0.1, then the floored position would be 0, the ceillinged size would be 1, and
the right would be 1, but the right of the original would be 1.05.